[PATCH v8 1/8] drm/bridge: analogix: Do not use device's drvdata

Heiko Stübner heiko at sntech.de
Thu Mar 1 07:39:18 PST 2018

Am Mittwoch, 10. Januar 2018, 17:23:41 CET schrieb Thierry Escande:
> From: Jeffy Chen <jeffy.chen at rock-chips.com>
> The driver that instantiates the bridge should own the drvdata, as all
> driver model callbacks (probe, remove, shutdown, PM ops, etc.) are also
> owned by its driver struct. Moreover, storing two different pointer
> types in driver data depending on driver initialization status is barely
> a good practice and in fact has led to many bugs in this driver.
> Let's clean up this mess and change Analogix entry points to simply
> accept some opaque struct pointer, adjusting their users at the same
> time to avoid breaking the compilation.
> Signed-off-by: Tomasz Figa <tfiga at chromium.org>
> Signed-off-by: Jeffy Chen <jeffy.chen at rock-chips.com>
> Signed-off-by: Thierry Escande <thierry.escande at collabora.com>
> Reviewed-by: Andrzej Hajda <a.hajda at samsung.com>
> Reviewed-by: Sean Paul <seanpaul at chromium.org>
> Acked-by: Jingoo Han <jingoohan1 at gmail.com>
> Acked-by: Archit Taneja <architt at codeaurora.org>

applied to drm-misc-next as it had Reviews/Acks from drm-bridge people


More information about the Linux-rockchip mailing list