[PATCH] pinctrl/rockchip: Don't call pinctrl_force_* for nothing
heiko at sntech.de
Thu Mar 1 01:52:12 PST 2018
Am Donnerstag, 1. März 2018, 10:32:22 CET schrieb Linus Walleij:
> On Sat, Feb 24, 2018 at 9:07 PM, Marc Zyngier <marc.zyngier at arm.com> wrote:
> > The rockchip pinctl driver calls pinctrl_force_default and
> > pinctrl_force_sleep on suspend resume, but seems to expect
> > that the outcome of these calls will be that nothing happens,
> > as the core code checks whether we're already in the right
> > state or not.
> > Or at least, that was what the core code was doing until
> > 981ed1bfbc ("pinctrl: Really force states during suspend/resume"),
> > which gives the "force" qualifier its actual meaning.
> > In turn, this breaks suspend/resume on the rk3399. So let's
> > change the rockchip code to do what it should have done from
> > the very begining, which is exactly *nothing*.
> > We take this opportunity to tidy-up the RK3288 GPIO6_C6 mux
> > resume workaround, making it symetrical to the suspend path.
> > Tested on a rk3399-based kevin Chromebook.
> > Fixes: 9198f509c888 ("pinctrl: rockchip: add suspend/resume functions")
> > Signed-off-by: Marc Zyngier <marc.zyngier at arm.com>
> I assume I should drop this patch for now and that
> Dough's long DTS patch with the long explanation was the
> right solution to the problem?
Correct this patch is not needed.
More information about the Linux-rockchip