[PATCH] pinctrl/rockchip: Don't call pinctrl_force_* for nothing

Florian Fainelli f.fainelli at gmail.com
Mon Feb 26 19:37:38 PST 2018

On February 24, 2018 12:07:31 PM PST, Marc Zyngier <marc.zyngier at arm.com> wrote:
>The rockchip pinctl driver calls pinctrl_force_default and
>pinctrl_force_sleep on suspend resume, but seems to expect
>that the outcome of these calls will be that nothing happens,
>as the core code checks whether we're already in the right
>state or not.
>Or at least, that was what the core code was doing until
>981ed1bfbc ("pinctrl: Really force states during suspend/resume"),
>which gives the "force" qualifier its actual meaning.
>In turn, this breaks suspend/resume on the rk3399. So let's
>change the rockchip code to do what it should have done from
>the very begining, which is exactly *nothing*.
>We take this opportunity to tidy-up the RK3288 GPIO6_C6 mux
>resume workaround, making it symetrical to the suspend path.
>Tested on a rk3399-based kevin Chromebook.

Glad you are not reverting the changes I did, but I can't comment whether this is the right think to do on such a Chromebook, FWIW:

Reviewed-by: Florian Fainelli <f.fainelli at gmail.com>


More information about the Linux-rockchip mailing list