[PATCH] ARM: dts: add phy-reset property for rk3066a-rayeager emac

Andrew Lunn andrew at lunn.ch
Tue Nov 7 07:59:47 PST 2017

> As a side question, which is mainly addressed to Sergei and Roger,
> I don't quite understand why PHY properties were initially added to
> MAC/MDIO bus device tree nodes, in my opinion they must be moved under
> PHY device tree nodes.

If you look at the implementation, they are not actually PHY
properties. They are MDIO properties. It is the MDIO driver using them
to perform an 'MDIO bus reset'. The property names are wrong.

The device tree structure could be better. It mixes the MAC and the
MDIO properties in the same node. It would of been better to have
separate nodes. 

The MDIO core now has equivalent functionality. So yes, it would be
better to use the generic MDIO properties, not these driver


More information about the Linux-rockchip mailing list