[PATCH v2 0/5] PM / Domains: Remove gpd_dev_ops.active_wakeup() callback
geert at linux-m68k.org
Thu Nov 2 02:14:37 PDT 2017
On Wed, Nov 1, 2017 at 11:10 AM, Ulf Hansson <ulf.hansson at linaro.org> wrote:
> On 31 October 2017 at 19:11, Geert Uytterhoeven <geert+renesas at glider.be> wrote:
>> It is quite common for PM Domains to require slave devices to be kept
>> active during system suspend if they are to be used as wakeup sources.
>> To enable this, currently each PM Domain or driver has to provide its
>> own gpd_dev_ops.active_wakeup() callback.
>> All existing callbacks either return always true, or a fixed value
>> depending on the PM Domain.
>> Hence this patch series simplifies active wakeup handling by replacing
>> the callback by a flag:
>> - Patch 1 adds a new new flag GENPD_FLAG_ACTIVE_WAKEUP, to be set by
>> PM Domain drivers that want to use the new handling,
>> - Patches 2-4 convert all existing users of the callback to the new
>> - Patch 5 removes the callback.
>> This series was extracted from "[PATCH 00/10] PM / Domain: renesas: Fix
>> active wakeup behavior", and retains only PM Domain changes to existing
>> Changes compared to v1 (most suggested by Ulf):
>> - Use the flag in se instead of setting up an "always true" callback,
>> - Convert the mediatek and rockchip PM Domain drivers,
>> - Remove the callback.
>> If this idea is accepted, I think it would be good to still queue the first
>> patch for v4.15. That would allow the changes to the PM Domain drivers
>> to go in through the respective platform trees in v4.16.
>> Then the final patch has to be postponed until v4.17.
>> Alternatively, everything can go in through the PM tree in one shot.
> For the series:
> Acked-by: Ulf Hansson <ulf.hansson at linaro.org>
> It's easier if everything goes via Rafael's PM tree. Moreover, this
> series is to me rather trivial, so I would actually recommend to pick
> it all for 4.15. Mainly because, moving too slowly forward, allows new
> users to show up of the callback you remove in patch5.
Obviously, that's fine for me.
Guess I've just became a bit too cautious with treewide changes ;-)
>> [RFC] ARM: shmobile: pm-rmobile: Use GENPD_FLAG_ACTIVE_WAKEUP
We already have an ack from Simon...
>> [RFC] soc: mediatek: Use GENPD_FLAG_ACTIVE_WAKEUP
>> [RFC] soc: rockchip: power-domain: Use GENPD_FLAG_ACTIVE_WAKEUP
... we still need one for mediatek and rockchip?
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
More information about the Linux-rockchip