[PATCH v2 3/5] PCI: rockchip: add remove() support
briannorris at chromium.org
Thu Mar 30 17:26:09 PDT 2017
On Thu, Mar 30, 2017 at 06:28:25PM -0500, Bjorn Helgaas wrote:
> On Fri, Mar 24, 2017 at 10:22:19AM -0700, Brian Norris wrote:
> > On Fri, Mar 24, 2017 at 09:25:41AM -0500, Bjorn Helgaas wrote:
> > > These don't have .remove:
> > >
> > > imx6_pcie_driver
> > > ls_pcie_driver
> > > armada8k_pcie_driver
> > > artpec6_pcie_driver
> > > dw_plat_pcie_driver
> > > hisi_pcie_driver
> > > hisi_pcie_almost_ecam_driver
> > > spear13xx_pcie_driver
> > > gen_pci_driver
> > I think these are all technically broken.
> Can we fix them all at the same time as you fix Rockchip? Maybe we
> should have a series that adds ".suppress_bind_attrs = true" to all
> these drivers,
Sure, I can do that.
> including Rockchip.
Huh? Why? So I can revert that in the next patch?
> Then you could have this current
> series to make Rockchip modular on top, if there's still value in it.
I do see value in it. That's the whole reason I wrote this patchset.
It's useful for stressing out certain behaviors that will happen all the
time (i.e., boot-time initialization, from platform probe, to bus init,
to client/EP init), via repeated bind/unbind (or modprobe/rmmod). It's
much faster than reboot testing.
Personally, I'd rather just patch the other drivers, and you can wait
until I follow through on that promise before applying my existing work
for the Rockchip driver, if that's what you'd prefer.
> If we find a common problem, I'd like to fix it everywhere we know
> about so it doesn't get forgotten or copied to even more places.
Sure. But you only just pointed out how broken several drivers were; I
didn't really notice :)
More information about the Linux-rockchip