[patch 1/5] pinctrl: samsung: Remove bogus irq_[un]mask from resource management

Linus Walleij linus.walleij at linaro.org
Fri Jun 30 05:12:12 PDT 2017

On Thu, Jun 29, 2017 at 11:33 PM, Thomas Gleixner <tglx at linutronix.de> wrote:

> The irq chip callbacks irq_request/release_resources() have absolutely no
> business with masking and unmasking the irq.
> The core code unmasks the interrupt after complete setup and masks it
> before invoking irq_release_resources().
> The unmask is actually harmful as it happens before the interrupt is
> completely initialized in __setup_irq().
> Remove it.
> Fixes: f6a8249f9e55 ("pinctrl: exynos: Lock GPIOs as interrupts when used as EINTs")
> Signed-off-by: Thomas Gleixner <tglx at linutronix.de>
> Cc: Tomasz Figa <tomasz.figa at gmail.com>
> Cc: Krzysztof Kozlowski <krzk at kernel.org>
> Cc: Sylwester Nawrocki <s.nawrocki at samsung.com>
> Cc: Linus Walleij <linus.walleij at linaro.org>
> Cc: Kukjin Kim <kgene at kernel.org>
> Cc: linux-arm-kernel at lists.infradead.org
> Cc: linux-samsung-soc at vger.kernel.org
> Cc: linux-gpio at vger.kernel.org

Reviewed-by: Linus Walleij <linus.walleij at linaro.org>

Does this patch have a dependency on the rest of the series or should
I just apply it as-is?

Linus Walleij

More information about the Linux-rockchip mailing list