[patch 1/5] pinctrl: samsung: Remove bogus irq_[un]mask from resource management

Krzysztof Kozlowski krzk at kernel.org
Thu Jun 29 23:02:20 PDT 2017

On Fri, Jun 30, 2017 at 4:47 AM, Tomasz Figa <tomasz.figa at gmail.com> wrote:
> Hi Thomas,
> 2017-06-30 6:33 GMT+09:00 Thomas Gleixner <tglx at linutronix.de>:
>> The irq chip callbacks irq_request/release_resources() have absolutely no
>> business with masking and unmasking the irq.
>> The core code unmasks the interrupt after complete setup and masks it
>> before invoking irq_release_resources().
>> The unmask is actually harmful as it happens before the interrupt is
>> completely initialized in __setup_irq().
>> Remove it.
> Good catch, thanks! (Note that the original patch of mine [1] did that
> in .irq_startup()/.irq_shutdown(), which was for some reason changed
> later, but I don't remember the exact story.)
> [1] https://patchwork.kernel.org/patch/4466431/
> Acked-by: Tomasz Figa <tomasz.figa at gmail.com>
> Sylwester, Krzysztof, would you be able to do some basic test?

I suppose this was not tested so yes - I have platforms do this. I
understand that checking any non-shared GPIO interrupt should be
sufficient to test, right?

Best regards,

More information about the Linux-rockchip mailing list