[patch 1/5] pinctrl: samsung: Remove bogus irq_[un]mask from resource management

Thomas Gleixner tglx at linutronix.de
Thu Jun 29 14:33:35 PDT 2017

The irq chip callbacks irq_request/release_resources() have absolutely no
business with masking and unmasking the irq.

The core code unmasks the interrupt after complete setup and masks it
before invoking irq_release_resources().

The unmask is actually harmful as it happens before the interrupt is
completely initialized in __setup_irq().

Remove it.

Fixes: f6a8249f9e55 ("pinctrl: exynos: Lock GPIOs as interrupts when used as EINTs")
Signed-off-by: Thomas Gleixner <tglx at linutronix.de>
Cc: Tomasz Figa <tomasz.figa at gmail.com>
Cc: Krzysztof Kozlowski <krzk at kernel.org>
Cc: Sylwester Nawrocki <s.nawrocki at samsung.com>
Cc: Linus Walleij <linus.walleij at linaro.org>
Cc: Kukjin Kim <kgene at kernel.org>
Cc: linux-arm-kernel at lists.infradead.org
Cc: linux-samsung-soc at vger.kernel.org
Cc: linux-gpio at vger.kernel.org
 drivers/pinctrl/samsung/pinctrl-exynos.c |    4 ----
 1 file changed, 4 deletions(-)

--- a/drivers/pinctrl/samsung/pinctrl-exynos.c
+++ b/drivers/pinctrl/samsung/pinctrl-exynos.c
@@ -205,8 +205,6 @@ static int exynos_irq_request_resources(
 	spin_unlock_irqrestore(&bank->slock, flags);
-	exynos_irq_unmask(irqd);
 	return 0;
@@ -226,8 +224,6 @@ static void exynos_irq_release_resources
 	shift = irqd->hwirq * bank_type->fld_width[PINCFG_TYPE_FUNC];
 	mask = (1 << bank_type->fld_width[PINCFG_TYPE_FUNC]) - 1;
-	exynos_irq_mask(irqd);
 	spin_lock_irqsave(&bank->slock, flags);
 	con = readl(bank->eint_base + reg_con);

More information about the Linux-rockchip mailing list