[PATCH] i2c: rk3x: Give the tuning value 0 during rk3x_i2c_v0_calc_timings

Wolfram Sang wsa at the-dreams.de
Thu Oct 27 06:11:21 PDT 2016

On Sat, Oct 22, 2016 at 04:43:42PM +0800, David Wu wrote:
> We found a bug that i2c transfer sometimes failed on 3066a board with
> stabel-4.8, the con register would be updated by uninitialized tuning
> value, it made the i2c transfer failed.
> So give the tuning value to be zero during rk3x_i2c_v0_calc_timings.
> Signed-off-by: David Wu <david.wu at rock-chips.com>

What I missed to say in my review:

Please use a subject line that describes WHY the change is needed not so
much WHAT is done. Like: "fix missing initialization causing boot

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-rockchip/attachments/20161027/c2981e1f/attachment-0001.sig>

More information about the Linux-rockchip mailing list