[RFC PATCH v2 4/4] mmc: dw_mmc-rockchip: disable biu clk and genpd if possible

Jaehoon Chung jh80.chung at samsung.com
Thu Oct 6 21:15:55 PDT 2016


On 09/30/2016 05:48 PM, Shawn Lin wrote:
> We could disable biu clk and power-off genpd if gpio
> card detect available.
> 
> Signed-off-by: Shawn Lin <shawn.lin at rock-chips.com>
> ---
> 
>  drivers/mmc/host/dw_mmc-rockchip.c | 18 +++++++++++++++++-
>  1 file changed, 17 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/mmc/host/dw_mmc-rockchip.c b/drivers/mmc/host/dw_mmc-rockchip.c
> index 3ad041c..e7b3b6d 100644
> --- a/drivers/mmc/host/dw_mmc-rockchip.c
> +++ b/drivers/mmc/host/dw_mmc-rockchip.c
> @@ -13,6 +13,7 @@
>  #include <linux/mmc/host.h>
>  #include <linux/mmc/dw_mmc.h>
>  #include <linux/of_address.h>
> +#include <linux/mmc/slot-gpio.h>
>  #include <linux/pm_runtime.h>
>  #include <linux/slab.h>
>  
> @@ -366,14 +367,29 @@ static int dw_mci_rockchip_remove(struct platform_device *pdev)
>  static int dw_mci_rockchip_runtime_suspend(struct device *dev)
>  {
>  	struct dw_mci *host = dev_get_drvdata(dev);
> +	int ret;
>  
> -	return dw_mci_runtime_suspend(host);
> +	ret = dw_mci_runtime_suspend(host);
> +	if (ret)
> +		return ret;
> +
> +	if (mmc_can_gpio_cd(host->slot[0]->mmc)) {

Can use cur_slot instead of slot[0]? And doesn't need to check "host->slot[]" or "host->cur_slot"?

Best Regards,
Jaehoon Chung

> +		clk_disable_unprepare(host->biu_clk);
> +		pm_runtime_put(dev);
> +	}
> +
> +	return 0;
>  }
>  
>  static int dw_mci_rockchip_runtime_resume(struct device *dev)
>  {
>  	struct dw_mci *host = dev_get_drvdata(dev);
>  
> +	if (mmc_can_gpio_cd(host->slot[0]->mmc)) {
> +		pm_runtime_get_sync(dev);
> +		clk_prepare_enable(host->biu_clk);
> +	}
> +
>  	return dw_mci_runtime_resume(host);
>  }
>  #endif /* CONFIG_PM */
> 




More information about the Linux-rockchip mailing list