[PATCH v3 13/13] clocksource/drivers/rockchip_timer: Prevent ftrace recursion

Alexander Kochetkov al.kochet at gmail.com
Tue Nov 29 07:36:11 PST 2016

Hello Heiko!
Thank you for patch review!

> 29 нояб. 2016 г., в 18:01, Heiko Stübner <heiko at sntech.de> написал(а):
> you introduced the issue yourself in patch 11/13. In general any patch should 
> never leave the kernel in a worse state than it was before, so no patch should 
> ever introduce known issues itself.


> In that line of thought, don't patches 10+11 introduce warnings about unused 
> functions as well when applied without patch 12?
7 - yes
10 - not
11 - yes

> 29 нояб. 2016 г., в 18:03, Heiko Stübner <heiko at sntech.de> написал(а):
> Then why do you need another patch to remove them and don't do that in the 
> patch removing their respective usage?

To make 7 more readable. Overwise patch messed up and unreadable.
It’s hard to track what going on in the patch.

> Maybe merge them?

I'll merge all of them.

here comment from another thead about the patches.

> 29 нояб. 2016 г., в 18:07, Robin Murphy <robin.murphy at arm.com> написал(а):
> 3288 (and probably anything newer) is irrelevant to this discussion, as
> it has the arch timer interface - that may be busted in other ways (such
> as not being correctly set up by firmware and not being always-on as it
> should), but frequency is not one of them. This only affects
> Cortex-A9/A5 based parts.

So I update comments for patches.

Looks, like I study archeology with my patches, as all new ARM chips not
affected by the problem anymore.


More information about the Linux-rockchip mailing list