[RFC PATCH 1/2] mmc: dw_mmc: remove redundant of set_bit and clear_bit
Jaehoon Chung
jh80.chung at samsung.com
Thu May 26 17:53:18 PDT 2016
Hi Shawn,
On 05/26/2016 12:07 PM, Shawn Lin wrote:
> dw_mci_get_cd have already dealed with these for
> both of internal card-detect and gpio card-detect.
s/dealed/dealt
This patch looks good to me. Could you resend the patch? not RFC.
Best Regards,
Jaehoon Chung
>
> Signed-off-by: Shawn Lin <shawn.lin at rock-chips.com>
>
> ---
>
> drivers/mmc/host/dw_mmc.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/mmc/host/dw_mmc.c b/drivers/mmc/host/dw_mmc.c
> index 829a6ee..cb30e91 100644
> --- a/drivers/mmc/host/dw_mmc.c
> +++ b/drivers/mmc/host/dw_mmc.c
> @@ -2616,10 +2616,7 @@ static int dw_mci_init_slot(struct dw_mci *host, unsigned int id)
> mmc->max_seg_size = mmc->max_req_size;
> }
>
> - if (dw_mci_get_cd(mmc))
> - set_bit(DW_MMC_CARD_PRESENT, &slot->flags);
> - else
> - clear_bit(DW_MMC_CARD_PRESENT, &slot->flags);
> + dw_mci_get_cd(mmc);
>
> ret = mmc_add_host(mmc);
> if (ret)
>
More information about the Linux-rockchip
mailing list