[PATCH v7 2/9] i2c: rk3x: use struct "rk3x_i2c_calced_timings"
dianders at chromium.org
Thu May 5 15:55:19 PDT 2016
On Wed, May 4, 2016 at 7:13 AM, David Wu <david.wu at rock-chips.com> wrote:
> Signed-off-by: David Wu <david.wu at rock-chips.com>
Usually folks like a description and not just a subject line. I'd add
a description like:
The "div_high" and "div_low" values are always used together. Group them
into a structure to make it easier to pass them both around. This
structure also provides a place for future calculated timings.
> Change in v7:
> - none
> drivers/i2c/busses/i2c-rk3x.c | 55 +++++++++++++++++++++++++------------------
> 1 file changed, 32 insertions(+), 23 deletions(-)
Other than the description, I think this looks fine.
IMHO this can be applied any time independent of any earlier patches.
Reviewed-by: Douglas Anderson <dianders at chromium.org>
More information about the Linux-rockchip