[PATCH v4.1 1/2] drm/rockchip: analogix_dp: introduce the pclk for grf
dianders at chromium.org
Wed Jun 22 22:16:28 PDT 2016
On Wed, Jun 22, 2016 at 6:58 PM, Yakir Yang <ykk at rock-chips.com> wrote:
> For RK3399's GRF module, if we want to operate the graphic related grf
> registers, we need to enable the pclk_vio_grf which supply power for VIO
> GRF IOs, so it's better to introduce an optional grf clock in driver.
> Signed-off-by: Yakir Yang <ykk at rock-chips.com>
> Hi all,
> This is an external patch for analogix_dp misc cleanup thread 
> : https://patchwork.kernel.org/patch/9175613/
> - Yakir
> Changes in v4.1:
> - Fix compiled error, sorry.
> "dp->cgfclk" --> 'dp->grfclk'
> Changes in v4:
> - Check the the error code properly, 'EPROBE_DEFER' should be returned,
> 'ENOENT' should assign a NULL point to grfclk, other errors should be
> regarded as failed. (Tomasz, Doug, reviewed at Google Gerrit)
> - Add the document about optional 'grf' clock (Tomasz, Doug, reviewed at Google Gerrit)
> Changes in v3:
> - Add this patch in v3
> .../display/rockchip/analogix_dp-rockchip.txt | 6 ++++++
> drivers/gpu/drm/rockchip/analogix_dp-rockchip.c | 23 +++++++++++++++++++---
> 2 files changed, 26 insertions(+), 3 deletions(-)
I probably would have split into two patches so the bindings was its
own patch, but I don't think it's strictly required.
In any case, this seems good to me.
Reviewed-by: Douglas Anderson <dianders at chromium.org>
More information about the Linux-rockchip