[PATCH v2 07/20] drm: mediatek: Rely on the default ->best_encoder() behavior
Matthias Brugger
matthias.bgg at gmail.com
Wed Jun 8 04:17:07 PDT 2016
On 07/06/16 13:48, Boris Brezillon wrote:
> We have a 1:1 relationship between connectors and encoders and the
> driver is relying on the atomic helpers: we can drop the custom
> ->best_encoder() implementation and let the core call
> drm_atomic_helper_best_encoder() for us.
>
> Signed-off-by: Boris Brezillon <boris.brezillon at free-electrons.com>
Reviewed-by: Matthias Brugger <matthias.bgg at gmail.com>
> ---
> drivers/gpu/drm/mediatek/mtk_dsi.c | 9 ---------
> 1 file changed, 9 deletions(-)
>
> diff --git a/drivers/gpu/drm/mediatek/mtk_dsi.c b/drivers/gpu/drm/mediatek/mtk_dsi.c
> index 2d808e5..7343ffc 100644
> --- a/drivers/gpu/drm/mediatek/mtk_dsi.c
> +++ b/drivers/gpu/drm/mediatek/mtk_dsi.c
> @@ -575,14 +575,6 @@ static int mtk_dsi_connector_get_modes(struct drm_connector *connector)
> return drm_panel_get_modes(dsi->panel);
> }
>
> -static struct drm_encoder *mtk_dsi_connector_best_encoder(
> - struct drm_connector *connector)
> -{
> - struct mtk_dsi *dsi = connector_to_dsi(connector);
> -
> - return &dsi->encoder;
> -}
> -
> static const struct drm_encoder_helper_funcs mtk_dsi_encoder_helper_funcs = {
> .mode_fixup = mtk_dsi_encoder_mode_fixup,
> .mode_set = mtk_dsi_encoder_mode_set,
> @@ -603,7 +595,6 @@ static const struct drm_connector_funcs mtk_dsi_connector_funcs = {
> static const struct drm_connector_helper_funcs
> mtk_dsi_connector_helper_funcs = {
> .get_modes = mtk_dsi_connector_get_modes,
> - .best_encoder = mtk_dsi_connector_best_encoder,
> };
>
> static int mtk_drm_attach_bridge(struct drm_bridge *bridge,
>
More information about the Linux-rockchip
mailing list