[PATCH] usb: dwc2: Add extra delay when forcing dr_mode

John Youn John.Youn at synopsys.com
Mon Feb 15 15:10:50 PST 2016


On 2/13/2016 1:41 PM, Michael Niewoehner wrote:
> Hi John,
> Hi Heiko,
> 
> on rk3188 25 ms don’t seem to be enough also.
> Increasing the sleep time to 50 ms solve the problem for me while 32 ms seem to be the absolute minimum.
> 
> Best regards
> Michael
> 
> 
> 
> Am 13.02.2016 um 22:13 schrieb Heiko Stuebner <heiko at sntech.de>:
> 
>> Am Donnerstag, 4. Februar 2016, 17:50:34 schrieb John Youn:
>>> Fixes an issue found on rockchip rk3036-based SOC platforms. For some
>>> reason, the existing msleep(25) is not enough after the force mode. The
>>> following patch was reported to fix the issue.
>>>
>>> This does increase the probe delay again slightly, but not up to the
>>> level it was before the original series of patches that this fixes. It
>>> does not cause any other issues when tested on Synopsys HAPS and Altera
>>> socfpga platforms.
>>>
>>> Need to revisit this series next release to see if we can address these
>>> issues without having an unconditional delay.
>>>
>>> Fixes: 09c96980dc72 ("usb: dwc2: Add functions to set and clear force
>>> mode") Reported-by: Caesar Wang <caesar.upstream at gmail.com>
>>> Tested-by: Caesar Wang <caesar.upstream at gmail.com>
>>> Signed-off-by: John Youn <johnyoun at synopsys.com>
>>
>> Tested-by: Heiko Stuebner <heiko at sntech.de>
>> (also on a rk3036 where I hit the described problem)
>>
>>

Ok thanks Heiko and Michael. I will update the patch and resend.

John



More information about the Linux-rockchip mailing list