[PATCH v3 1/5] thermal: rockchip: improve conversion error messages
wxt at rock-chips.com
Mon Dec 12 02:47:30 PST 2016
在 2016年11月30日 13:04, Eduardo Valentin 写道:
> On Mon, Nov 28, 2016 at 09:47:29PM -0800, Brian Norris wrote:
>>>> + __func__, table.mode);
>>> Given that we are improving messages, would it be more informative to
>>> say that you have an invalid table mode?
>> I considered the mode and ID listing to go hand in hand, so it was the
>> whole table that is wrong. But it is just as well to say the "table
>> mode" is wrong.
>> Maybe even better: "%s: unknown table mode: %d\n".
> Yup, that works for me, even better.
Done. Sorry for delay.
>> And I guess same answer for patch 4, where you had the same question.
>>>> + return -EINVAL;
> Linux-rockchip mailing list
> Linux-rockchip at lists.infradead.org
More information about the Linux-rockchip