[PATCH v2 1/2] devicetree: i2c-hid: Add Wacom digitizer + regulator support
briannorris at chromium.org
Mon Dec 5 15:54:09 PST 2016
On Mon, Dec 05, 2016 at 05:42:48PM -0600, Rob Herring wrote:
> On Wed, Nov 30, 2016 at 05:21:27PM -0800, Brian Norris wrote:
> > From: Caesar Wang <wxt at rock-chips.com>
> > Add a compatible string and regulator property for Wacom W9103
> > digitizer. Its VDD supply may need to be enabled before using it.
> > Signed-off-by: Caesar Wang <wxt at rock-chips.com>
> > Cc: Rob Herring <robh+dt at kernel.org>
> > Cc: Jiri Kosina <jikos at kernel.org>
> > Cc: linux-input at vger.kernel.org
> > Signed-off-by: Brian Norris <briannorris at chromium.org>
> > ---
> > v1 was a few months back. I finally got around to rewriting it based on
> > DT binding feedback.
> > v2:
> > * add compatible property for wacom
> > * name the regulator property specifically (VDD)
> > Documentation/devicetree/bindings/input/hid-over-i2c.txt | 6 +++++-
> > 1 file changed, 5 insertions(+), 1 deletion(-)
> Acked-by: Rob Herring <robh at kernel.org>
Thanks but (unfortunately) there've been 2 new versions since then.
Specifically, Benjamin NACK'ed this patch and requested we NOT include
device/manufacturer-specific compatible properties here. In fact, the
binding is still rather generic and IMO (and in Benjamin's opinion)
doesn't really need to be restricted to a specific device.
Please consider reviewing Benjamin's requests and my recent changes.
Benjamin has one small remaining comment on v4, and I plan to send the
5th (and final?) version once I'm confident you and Benjamin agree :)
More information about the Linux-rockchip