[PATCH] mmc: sdhci-of-arasan: Properly set corecfg_clockmultipler on rk3399

Doug Anderson dianders at chromium.org
Fri Aug 26 08:46:33 PDT 2016


On Fri, Aug 26, 2016 at 1:31 AM, Heiko Stübner <heiko at sntech.de> wrote:
> The aclk_emmc_grf is (similar to aclk_vio_grf etc) part of the emmc block.

Right now aclk_emmc_grf is set as CLK_IGNORE_UNUSED, which is my least
favorite clock property.  ;)

Due to the parenting structure and the fact that we just added
"aclk_emmc_noc" as a critical clock, I believe that this means that
aclk_emmc_grf will never turn off.  It would be awfully nice if you
could send up a patch to actually turn the "grf" clock on when needed
and turn it off when not needed.  That would let us remove the
"CLK_IGNORE_UNUSED" from all of the eMMC clocks in rk3399.

I noticed you send v2 of your patch series and that looks fine to me.
The issue with not handling the "grf" clock is not a new one and
shouldn't block your patch.  ...but it would still be nice to handle


More information about the Linux-rockchip mailing list