[PATCH v6] i2c: rk3x: add i2c support for rk3399 soc

Andy Shevchenko andy.shevchenko at gmail.com
Thu Apr 21 15:00:08 PDT 2016

On Tue, Apr 19, 2016 at 4:55 PM, David Wu <david.wu at rock-chips.com> wrote:
> From: David Wu <wdc at rock-chips.com>
> - new method to caculate i2c timings for rk3399:
>   There was an timing issue about "repeated start" time at the I2C
>   controller of version0, controller appears to drop SDA at .875x (7/8)
>   programmed clk high. On version 1 of the controller, the rule(.875x)
>   isn't enough to meet tSU;STA
>   requirements on 100k's Standard-mode. To resolve this issue,
>   sda_update_config, start_setup_config and stop_setup_config for I2C
>   timing information are added, new rules are designed to calculate
>   the timing information at new v1.
> - pclk and function clk are separated at rk3399.
> - support i2c highspeed mode: 1.7MHz for rk3399

Remove redundant parens in cases like
1. x * (a->b)
2. x = (a + b);

Don't touch pieces of code that are not related (you removed one empty
line without any reason).

With Best Regards,
Andy Shevchenko

More information about the Linux-rockchip mailing list