[PATCH 2/2] ARM: dts: change gpio-key,wakeup property to boolean

Sudeep Holla sudeep.holla at arm.com
Tue Oct 13 07:26:07 PDT 2015

On 13/10/15 15:07, Rob Herring wrote:
> On Tue, Oct 13, 2015 at 8:32 AM, Sudeep Holla <sudeep.holla at arm.com> wrote:
>> Keyboard driver for GPIO buttons(gpio-keys) checks for the legacy
>> "gpio-key,wakeup" boolean property to enable gpio buttons as wakeup
>> source.
>> Few dts files assign value "1" to gpio-key,wakeup and in one instance a
>> value "0" is assigned probably assuming it won't be enabled as a wakeup
>> source. Since the presence of the boolean property indicates it is
>> enabled, value of "0" have no value.
>> This patch removes the property where value "0" is assigned and removes
>> the value "1" in most of the other cases.
> Why don't you just change everything to wakeup-source.

Agreed, I wanted to do that but was not sure if that's acceptable.
I will update it, now I know that you are fine with it.

I also plan to find all the variety of bindings we have and fix them
retaining only those which are handled in the current kernel code as
legacy support.


More information about the Linux-rockchip mailing list