[PATCH] ARM: use "depends on" for SoC configs instead of "if" after prompt

Shawn Guo shawnguo at kernel.org
Tue Nov 24 01:30:08 PST 2015

On Mon, Nov 16, 2015 at 12:06:10PM +0900, Masahiro Yamada wrote:
> Many ARM sub-architectures use prompts followed by "if" conditional,
> but it is wrong.
> Please notice the difference between
>     config ARCH_FOO
>             bool "Foo SoCs" if ARCH_MULTI_V7
> and
>     config ARCH_FOO
>             bool "Foo SoCs"
>             depends on ARCH_MULTI_V7
> These two are *not* equivalent!
> In the former statement, it is not ARCH_FOO, but its prompt that
> depends on ARCH_MULTI_V7.  So, it is completely valid that ARCH_FOO
> is selected by another, but ARCH_MULTI_V7 is still disabled. As it is
> not unmet dependency, Kconfig never warns.  This is probably not what
> you want.
> The former should be used only when you need to do so, and you really
> understand what you are doing.  (In most cases, it should be wrong!)
> For enabling/disabling sub-architectures, the latter is always correct.
> As a good side effect, this commit fixes some entries over 80 columns
> (mach-imx, mach-integrator, mach-mbevu).
> Signed-off-by: Masahiro Yamada <yamada.masahiro at socionext.com>
> ---
>  arch/arm/mach-imx/Kconfig        |  6 ++++--

Acked-by: Shawn Guo <shawnguo at kernel.org>

More information about the Linux-rockchip mailing list