[PATCH] ARM: use "depends on" for SoC configs instead of "if" after prompt
patrice.chotard at st.com
Mon Nov 16 04:32:49 PST 2015
On 11/16/2015 04:06 AM, Masahiro Yamada wrote:
> Many ARM sub-architectures use prompts followed by "if" conditional,
> but it is wrong.
> Please notice the difference between
> config ARCH_FOO
> bool "Foo SoCs" if ARCH_MULTI_V7
> config ARCH_FOO
> bool "Foo SoCs"
> depends on ARCH_MULTI_V7
> These two are *not* equivalent!
> In the former statement, it is not ARCH_FOO, but its prompt that
> depends on ARCH_MULTI_V7. So, it is completely valid that ARCH_FOO
> is selected by another, but ARCH_MULTI_V7 is still disabled. As it is
> not unmet dependency, Kconfig never warns. This is probably not what
> you want.
> The former should be used only when you need to do so, and you really
> understand what you are doing. (In most cases, it should be wrong!)
> For enabling/disabling sub-architectures, the latter is always correct.
> As a good side effect, this commit fixes some entries over 80 columns
> (mach-imx, mach-integrator, mach-mbevu).
> Signed-off-by: Masahiro Yamada <yamada.masahiro at socionext.com>
> I hope this patch is applied to ARM-SOC, but am CCing Kbuild ML
> because the correct understanding of Kconfig is required for this patch.
> diff --git a/arch/arm/mach-sti/Kconfig b/arch/arm/mach-sti/Kconfig
> index 125865d..736abe6 100644
> --- a/arch/arm/mach-sti/Kconfig
> +++ b/arch/arm/mach-sti/Kconfig
> @@ -1,5 +1,6 @@
> menuconfig ARCH_STI
> - bool "STMicroelectronics Consumer Electronics SOCs" if ARCH_MULTI_V7
> + bool "STMicroelectronics Consumer Electronics SOCs"
> + depends on ARCH_MULTI_V7
> select ARM_GIC
> select ST_IRQCHIP
> select ARM_GLOBAL_TIMER
For STI part:
Acked-by: Patrice Chotard <patrice.chotard at st.com>
More information about the Linux-rockchip