[PATCH v1] net: stmmac: Free rx_skbufs before realloc

David Miller davem at davemloft.net
Tue Nov 24 10:09:24 PST 2015

From: Shunqian Zheng <zhengsq at rock-chips.com>
Date: Sun, 22 Nov 2015 16:44:18 +0800

> From: ZhengShunQian <zhengsq at rock-chips.com>
> The init_dma_desc_rings() may realloc the rx_skbuff[] when
> suspend and resume. This patch free the rx_skbuff[] before
> reallocing memory.
> Signed-off-by: ZhengShunQian <zhengsq at rock-chips.com>

This isn't really the right way to fix this.

I see two reasonable approaches:

1) suspend liberates the RX ring, although this approach is less

2) resume doesn't try to allocate already populated RX ring

Freeing the whole RX ring just to allocate it again immediately
makes no sense at all and is wasteful work.

More information about the Linux-rockchip mailing list