[PATCH] pinctrl: make pinctrl_register() return proper error code

Laurent Pinchart laurent.pinchart at ideasonboard.com
Tue Jun 9 09:54:08 PDT 2015

Hello Yamada-san,

Thank you for the patch.

On Tuesday 09 June 2015 13:01:16 Masahiro Yamada wrote:
> Currently, pinctrl_register() just returns NULL on error, so the
> callers can not know the exact reason of the failure.
> Some of the pinctrl drivers return -EINVAL, some -ENODEV, and some
> -ENOMEM on error of pinctrl_register(), although the error code
> might be different from the real cause of the error.
> This commit reworks pinctrl_register() to return the appropriate
> error code and modifies all of the pinctrl drivers to use IS_ERR()
> for the error checking and PTR_ERR() for getting the error code.
> Signed-off-by: Masahiro Yamada <yamada.masahiro at socionext.com>
> ---
> This patch is based on linux-pinctrl/devel
> (Commit 7164873e7c69d6bab74726debc3b495a86332b1f).
> I think I converted all of the pinctrl drivers, but just in case,
> I'd like the driver maintainers to check this patch out.



>  drivers/pinctrl/core.c                        | 17 ++++++++++-------
>  drivers/pinctrl/sh-pfc/pinctrl.c              |  4 ++--

Acked-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>


Laurent Pinchart

More information about the Linux-rockchip mailing list