[PATCH 0/2] drm/rockchip: Optimization vop dpms control

Mark Yao mark.yao at rock-chips.com
Wed Jan 21 23:05:31 PST 2015

drm dpms have many power modes, ON,OFF,SUSPEND,STANDBY, etc.
but vop only have enable/disable mode, maybe case such bug:
 --> DRM_DPMS_ON: power on vop
 --> DRM_DPMS_SUSPEND: power off vop
 --> DRM_DPMS_OFF: already power off at SUSPEND, crash
so use a bool val is more suitable.

another problem at vop_crtc_dpms:
  vop_enable()->drm_vblank_on, drm_vblank_on may call vop
enable vblank. if it happen, vblank enable would failed,
then cause irq status error. because is_enabled value is set
after drm_vblank_on.

Mark Yao (2):
  drm/rockchip: vop use is_enabled instead of dpms mode
  drm/rockchip: vop: set vop enabled after enable iommu

 drivers/gpu/drm/rockchip/rockchip_drm_fbdev.c |    2 +-
 drivers/gpu/drm/rockchip/rockchip_drm_gem.c   |   17 +++++------------
 drivers/gpu/drm/rockchip/rockchip_drm_gem.h   |    3 +--
 3 files changed, 7 insertions(+), 15 deletions(-)


More information about the Linux-rockchip mailing list