[PATCH 2/2] drm/rockchip: Send events for same-fb flips

Daniel Stone daniel at fooishbar.org
Wed Dec 2 06:07:05 PST 2015


Hi Mark, Caesar,

On 2 December 2015 at 01:01, Mark yao <mark.yao at rock-chips.com> wrote:
> On 2015年11月23日 15:46, Caesar Wang wrote:
>> There is a warning for building.
>>
>> CC drivers/gpu/drm/rockchip/rockchip_drm_vop.o
>> drivers/gpu/drm/rockchip/rockchip_drm_vop.c:753:32: warning:
>> 'vop_win_last_pending_fb' defined but not used [-Wunused-function]
>>
>> Maybe, we can also remove the vop_win_last_pending_fb() function.

You're absolutely right, and I have removed this in the next patchset,
which I will find the time to post shortly.

> Can you test this problem with my new atomic patches? I think atomic patch
> fix the problem.

I need some more time to do a full review of the atomic work. But
either way, atomic is not appropriate for a -fixes pull - I would like
to see this in 4.4 if possible, rather than 4.6.

Cheers,
Daniel



More information about the Linux-rockchip mailing list