[PATCH 2/2] drm/rockchip: make irq variable signed

Heiko Stübner heiko at sntech.de
Sat Apr 18 09:30:25 PDT 2015


platform_get_irq() can return negative error values and we already test for
these. Therefore the variable holding this value should be signed to not
loose error values.

Reported-by: David Binderman <dcb314 at hotmail.com>
Signed-off-by: Heiko Stuebner <heiko at sntech.de>
---
 drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c
index ccb0ce0..bde1c1e 100644
--- a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c
+++ b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c
@@ -104,7 +104,7 @@ struct vop {
 	/* lock vop irq reg */
 	spinlock_t irq_lock;
 
-	unsigned int irq;
+	int irq;
 
 	/* vop AHP clk */
 	struct clk *hclk;
-- 
2.1.4





More information about the Linux-rockchip mailing list