drivers/gpu/drm/rockchip/rockchip_drm_vop.c:1384: possible bad if test ?

[David Binderman]

Hello there,

[linux-4.0-rc7/drivers/gpu/drm/rockchip/rockchip_drm_vop.c:1384]: (style) Checking if unsigned variable 'irq' is less than zero.

    vop->irq = platform_get_irq(pdev, 0);
    if (vop->irq < 0) {
  
but

linux-4.0-rc7/include/linux/platform_device.h:extern int platform_get_irq(struct platform_device *, unsigned int);

Suggest put return value from platform_get_irq into an int, then
sanity check it, then put it into vop->irq.

Regards

David Binderman