[PATCH v7 3/5] ARM: dts: add RK3xxx CPU Thermal data

Doug Anderson dianders at chromium.org
Tue Sep 30 11:35:53 PDT 2014


On Tue, Sep 30, 2014 at 11:24 AM, Doug Anderson <dianders at chromium.org> wrote:
> Caesar,
> On Sun, Sep 28, 2014 at 3:38 AM, Caesar Wang <caesar.wang at rock-chips.com> wrote:
>> This patch changes a dtsi file to contain the thermal data
>> on RK3288 and later SoCs. This data will
>> enable a thermal shutdown over 125C.
>> Signed-off-by: Caesar Wang <caesar.wang at rock-chips.com>
>> ---
>>  arch/arm/boot/dts/rk3xxx-cpu-thermal.dtsi | 32 +++++++++++++++++++++++++++++++
>>  1 file changed, 32 insertions(+)
>>  create mode 100644 arch/arm/boot/dts/rk3xxx-cpu-thermal.dtsi
> I haven't done lots of review of this series, but I did notice that
> this file has bad spacing.  It's fairly obvious in your gerrit patch
> <https://chromium-review.googlesource.com/#/c/220270/1/arch/arm/boot/dts/rk3xxx-cpu-thermal.dtsi>
> because gerrit (by default) shows you "tab" characters...
> In general you should use tab for indentation, not spaces.  You seem
> to use a mix of the two.

I suppose I should also point out that it's generally not great to
name things "rk3xxx" since it makes too many predictions about how
future products will behave.  It's better to name things after the
first relevant product.  I'd just name this "rk3288-cpu-thermal.dtsi".


More information about the Linux-rockchip mailing list