[PATCH v4 6/8] clk: rockchip: add new clock-type for the cpuclk

Doug Anderson dianders at chromium.org
Fri Sep 26 13:03:24 PDT 2014


Heiko,

On Fri, Sep 26, 2014 at 11:53 AM, Heiko Stuebner <heiko at sntech.de> wrote:
> +struct clk *rockchip_clk_register_cpuclk(const char *name,
> +                       const char **parent_names, u8 num_parents,
> +                       const struct rockchip_cpuclk_reg_data *reg_data,
> +                       struct rockchip_cpuclk_rate_table *rates, int nrates,

It would be nice if this was "const struct rockchip_cpuclk rate_table
*rates" here and elsewhere.  It's OK if we make it const here even if
we can't figure out how to make the tables "initconst".

...but it sure seems like that could happen in a followup patch, so:

Reviewed-by: Doug Anderson <dianders at chromium.org>

On a rk3288-board:

Tested-by: Doug Anderson <dianders at chromium.org>



More information about the Linux-rockchip mailing list