[PATCH v4 RFC] i2c: rk3x: handle dynamic clock rate changes correctly

Doug Anderson dianders at chromium.org
Mon Sep 22 16:20:07 PDT 2014


On Mon, Sep 22, 2014 at 2:36 PM, Max Schwarz <max.schwarz at online.de> wrote:
> +       /*
> +        * We might be called from rk3x_i2c_probe or from the clk rate change
> +        * notifier. In that case, the i2c clk is not running. So enable it
> +        * explicitly here during the register write.

I still would have changed this comment to at least do "s/In that
case/in both cases"
...but I don't really care that much about this one, so:

Reviewed-by: Doug Anderson <dianders at chromium.org>

I've tested that this patch doesn't break my rk3288 board (though just
like you, I can't test the dynamic rate changes), so:

Tested-by: Doug Anderson <dianders at chromium.org>

More information about the Linux-rockchip mailing list