[PATCH] i2c-rk3x: move setup to the earlier subsys initcall
wsa at the-dreams.de
Mon Sep 22 10:13:27 PDT 2014
> In general you are correct. You can get by with lots of probe
> deferrals. I don't personally know of any case where things are
> broken with the current code, but it's really nice to avoid the
> deferrals if possible.
Yes, we all want proper dependencies and ordering, yet deferred probing
is the best we have.
> Given that this is a core SoC i2c bus and is used for _a lot_ of
> external connectivity (including for connecting to the primary
> regulator on most boards), bumping up the priority in the init order
> makes a lot of sense to me.
> This also matches the i2c busses of most other major SoCs. A selected
> few examples:
They were "lucky" to be around before deferred probing and using
subsys_initcall was always considered a hack. I am not accepting new
users of this hack unless there is really no other solution.
So, NACK, since it doesn't solve a problem.
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 819 bytes
Desc: Digital signature
More information about the Linux-rockchip