[PATCH v5 2/6] pinctrl: rockchip: save and restore gpio6_c6 pinmux in suspend/resume

[Chris Zhong]

On 10/30/2014 04:02 AM, Heiko Stübner wrote:
> Am Mittwoch, 29. Oktober 2014, 09:26:39 schrieb Doug Anderson:
>> Chris,
>>
>> On Tue, Oct 28, 2014 at 7:31 AM, Heiko Stübner <heiko at sntech.de> wrote:
>>> Am Montag, 27. Oktober 2014, 21:47:26 schrieb Chris Zhong:
>>>> Save and restore the gpio6_c6 pinmux setting, since Maskrom of RK3288
>>>> would modify it to sdmmc0_det, so it need to be restored to the correct
>>>> setting after resume from Maskrom.
>>> Does the maskrom only touch the iomux or also stuff like pull-bias or
>>> drive
>>> strength for this pin?
>>>
>>> Also could you please look up if the maskrom on rk3066a and rk3188 does
>>> something similar. While not strictly necessary for this patch, I'd like
>>> the driver to not diverge in functionality for to long.
>>>
>>>
>>> Otherwise it looks fine for the time being.
>>>
>>> Tested-by: Heiko Stuebner <heiko at sntech.de>
>>> Reviewed-by: Heiko Stuebner <heiko at sntech.de>
>> I notice that you posted patch v6 but you didn't respond to Heiko's
>> questions here and made no changes in v6.
>>
>> Can you please answer Heiko's questions?  The questions about whether
>> the pull-bias and drive also need to be reset would be good to get
>> answered.
> and also how the other socs 3066a and 3188 behave in this regard would be
> really nice to know. Because otherwise this might be forgotten when we
> implement suspend on those and result in us searching for reason why it might
> fail then.
Hi, Heiko
sorry for I did not respond promptly.

RK3288 maskrom only change the iomux function setting, does not change 
pull-bias and drive strength.

And RK3066A and RK3188 don't support turn ARM off during suspend,
so they have not this problem, since they wouldn't go to maskrom during 
resume.

>
> Thanks
> Heiko
>
> _______________________________________________
> Linux-rockchip mailing list
> Linux-rockchip at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-rockchip
>
>
>