[PATCH v5 6/6] ARM: dts: add RK3288 suspend support

[Heiko Stübner]

Am Montag, 27. Oktober 2014, 21:47:30 schrieb Chris Zhong:
> add pmu_intmem node for suspend, add global_pwroff pinctrl.
> The pmu_intmem is used to store the resume code.
> global_pwroff is held low level at work, it would be pull to high
> when entering suspend. reference this in the board DTS file since
> some boards need it.
> 
> Signed-off-by: Tony Xie <xxx at rock-chips.com>
> Signed-off-by: Chris Zhong <zyw at rock-chips.com>
> 
> ---
> 
> Changes in v5:
> - change size to 4k
> 
> Changes in v4: None
> Changes in v3: None
> Changes in v2:
> - put "rockchip,rk3288-pmu-sram" to first
> 
>  arch/arm/boot/dts/rk3288.dtsi |   11 +++++++++++
>  1 file changed, 11 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/rk3288.dtsi b/arch/arm/boot/dts/rk3288.dtsi
> index 874e66d..00dd9d7 100644
> --- a/arch/arm/boot/dts/rk3288.dtsi
> +++ b/arch/arm/boot/dts/rk3288.dtsi
> @@ -439,6 +439,11 @@
>  		status = "disabled";
>  	};
> 
> +	pmu_intmem at ff720000 {

the node name should be a generic descriptor of what it is, so I guess 
something like

	sram at ff720000

would be a better choice.


> +		compatible = "rockchip,rk3288-pmu-sram", "mmio-sram";
> +		reg = <0xff720000 0x1000>;
> +	};
> +
>  	pmu: power-management at ff730000 {
>  		compatible = "rockchip,rk3288-pmu", "syscon";
>  		reg = <0xff730000 0x100>;
> @@ -634,6 +639,12 @@
>  			bias-disable;
>  		};
> 
> +		sleep {
> +			global_pwroff: global-pwroff {

shouldn't this global_pwroff pinsetting also be used somewhere?


> +				rockchip,pins = <0 0 RK_FUNC_1 &pcfg_pull_none>;
> +			};
> +		};
> +
>  		i2c0 {
>  			i2c0_xfer: i2c0-xfer {
>  				rockchip,pins = <0 15 RK_FUNC_1 &pcfg_pull_none>,


Heiko