[PATCH v10 0/4] This suspend patch is only support cut off the power of cpu and some external
khilman at kernel.org
Wed Dec 3 11:23:26 PST 2014
Chris Zhong <zyw at rock-chips.com> writes:
> I have test these patches on evb board base on next-20141128 with a
> defconfig, and with u-boot.
> As Doug said, we need below 3 patches for resume.
> 1.https://patchwork.kernel.org/patch/5051881/ - clocksource:
> arch_timer: Allow the device tree to specify uninitialized timer
> 2.https://patchwork.kernel.org/patch/5363671/ - clocksource:
> arch_timer: Fix code to use physical timers when requested
> 3.https://patchwork.kernel.org/patch/5382141/ - ARM: dts: rk3288: add
> And it will auto wakeup, as Heiko said in v8.
OK, with your series plus those 3 patches on top of next-20141128, I'm
now seeing it auto-wakeup, either with multi_v7_defconfig or Heiko's
> But I have never notice before, since the u-boot never enable edp, and
> I use the coreboot with edp display. Actually it is a bug in rk3288,
> the rk3288 have not 27Mhz clock source, but the edp initially set to
> this non-existent clock. At this time, edp is working on a unknown
> state, and it always bring a interrupt, this interrupt avoid system
> enter suspend.
I see, good find!
> So if we want to enter suspend normally, the
> edp_24m_sel(bit 15) of CRU_CLKSEL28_CON(0xff7600d0) must be set to 1.
I didn't try your u-boot fix, but it sounds like there should be a kernel
fix for this. Why doesn't the disabling of unused clocks put the EDP
into a safe/disabled state?
More information about the Linux-rockchip