[PATCH 2/2] ASoC: rockchip: i2s: add support for grabbing output clock to codec

Doug Anderson dianders at chromium.org
Tue Dec 2 21:27:15 PST 2014


Jianqun,

On Tue, Dec 2, 2014 at 5:51 PM, Jianqun Xu <jay.xu at rock-chips.com> wrote:
> From: Sonny Rao <sonnyrao at chromium.org>
>
> We need to claim the clock which is driving the codec so that when we enable
> clock gating, we continue to clock the codec when needed.  I make this an
> optional clock since there might be some applications where we don't need it
> but can still use the I2S block.
>
> Signed-off-by: Sonny Rao <sonnyrao at chromium.org>
> Signed-off-by: Jianqun Xu <jay.xu at rock-chips.com>
> ---
>  sound/soc/rockchip/rockchip_i2s.c | 12 ++++++++++++
>  1 file changed, 12 insertions(+)

This looks fine to me now and you can add:

Reviewed-by: Doug Anderson <dianders at chromium.org>

...but you lost the whole CC list and this definitely needs to include
broonie in the "To" list, so you need to repost.  When you repost it
would be super helpful if you could include a version number and a
list of changes between versions.



More information about the Linux-rockchip mailing list