[PATCH 2/2] ASoC: rockchip: i2s: add support for grabbing output clock to codec

Doug Anderson dianders at chromium.org
Tue Dec 2 21:18:35 PST 2014

On Tue, Dec 2, 2014 at 5:03 PM, Jianqun <xjq at rock-chips.com> wrote:
> Hi Doug:
> 在 12/03/2014 01:54 AM, Doug Anderson 写道:
>> Jianqun,
>> This ought to be a "v3" patch and ideally ought to describe
>> differences from v2 (after the cut).  Please have Kever or Chris
>> review your next patch before sending it out since I think they are
>> familiar with the process.

You still seem to be missing versions in your subject line and missing
info on what changed version to version.  The latest version you just
sent (v4?) is still missing it.

Unless Mark says so then I don't think you need to spin this series,
but please try to add that in the future.

>> You still forgot the blank line here requested by Heiko.  Please try
>> again.  See <https://patchwork.kernel.org/patch/5334991/>
> Although I thought there needn't a blank ~, I wll add it next patch

That would have been OK, but in that case you should have responded to
Heiko's patch and explained that you weren't taking his feedback (and
why you weren't).


More information about the Linux-rockchip mailing list