[PATCH] ARM: rockchip: Convert resume code to C

Linus Walleij linus.walleij at linaro.org
Tue Dec 2 05:34:32 PST 2014

On Tue, Dec 2, 2014 at 10:33 AM, Arnd Bergmann <arnd at arndb.de> wrote:
> On Monday 01 December 2014 15:04:59 Doug Anderson wrote:

>> Adding that code in assembly seems like a very, very bad idea.
>> Certainly my patch could wait until the DDR code is ready to be posted
>> upstream if that made sense.  One advantage of waiting is that it's
>> possible that the DDR code might end up moving elsewhere if it made
>> sense to have it part of a memory controller driver or something like
>> that.
> AFAICT, the quantenna implementation is similar to the itcm/dtcm
> stuff we already have (but are not using upstream), so I wonder
> why we can't use that here too, see Documentation/arm/tcm.txt

I agree. The TCM __tcm* macros to tag code and data for the TCM
can be used by any mechanism by modifying mem_init() in

If the name is disturbing the __tcm* function can be renamed
__onchip* simply.

It will never work on multiplatform however, and if some real change
shall come to that, something like Russ Dills patches and a
generic approach to dynamic loading of onchip executables is

I had hopes of replacing the TCM mechanism with that
scheme, people also want to load onchip programs from
userspace as it happens, that would be the right way to go.

Linus Walleij

More information about the Linux-rockchip mailing list