[PATCH] clk: tenstorrent: Assign .num before accessing .hws
Drew Fustini
fustini at kernel.org
Wed Sep 23 19:13:22 PDT 2026
On Thu, Sep 10, 2026 at 01:47:31AM +0100, Aamir Ahmed wrote:
> On Tue, Sep 08, 2026 at 11:56:12AM +0200, Gustavo A. R. Silva wrote:
> > Looks like variable num_clks can be removed entirely, and just do:
> >
> > clk_data->num = data->num;
>
> Yes - it is only read once and data is const.
>
> Thanks for reviewing, and thanks Anirudh for testing. For the redundant
> variable, since this has a stable Cc, perhaps we can keep the diff
> minimal here and I can send the cleanup as a follow-up once it lands?
>
> Kind Regards
>
> Aamir A.
Thanks for sending the patch.
I would prefer a v2 with this change in order to avoid a trivial patch
later. We are still in the process of upstreaming support for the
Atlantis platform, so there are no users yet that would be affected by
this issue.
Thanks,
Drew
More information about the linux-riscv
mailing list