[PATCH 6/9] pinctrl: ultrarisc: Add UltraRISC DP1000 pinctrl driver

[Jia Wang]

On 2026-05-21 23:09 +0200, Krzysztof Kozlowski wrote:
> On 15/05/2026 03:18, Jia Wang via B4 Relay wrote:
> > From: Jia Wang <wangjia at ultrarisc.com>
> > 
> > Add pinctrl driver for UltraRISC DP1000 pinctrl controller.
> > 
> > Signed-off-by: Jia Wang <wangjia at ultrarisc.com>
> > ---
> >  MAINTAINERS                                   |   1 +
> >  drivers/pinctrl/Kconfig                       |   1 +
> >  drivers/pinctrl/Makefile                      |   1 +
> >  drivers/pinctrl/ultrarisc/Kconfig             |  23 +
> >  drivers/pinctrl/ultrarisc/Makefile            |   4 +
> >  drivers/pinctrl/ultrarisc/pinctrl-dp1000.c    | 112 ++++
> >  drivers/pinctrl/ultrarisc/pinctrl-ultrarisc.c | 746 ++++++++++++++++++++++++++
> >  drivers/pinctrl/ultrarisc/pinctrl-ultrarisc.h |  71 +++
> >  8 files changed, 959 insertions(+)
> 
> Organize your patchset correctly. Such style:
> DTS
> pinctrl
> DTS
> 
> is very confusing and discouraged. See submitting patches in DT directory.
> 
>

Got it. I will reorganize the patchset in v2.

> > 
> > diff --git a/MAINTAINERS b/MAINTAINERS
> > index 832e01898ae5..ecd87d58f28c 100644
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -27364,6 +27364,7 @@ M:	Jia Wang <wangjia at ultrarisc.com>
> >  L:	linux-gpio at vger.kernel.org
> >  S:	Maintained
> >  F:	Documentation/devicetree/bindings/pinctrl/ultrarisc,dp1000-pinctrl.yaml
> > +F:	drivers/pinctrl/ultrarisc/*
> >  F:	include/dt-bindings/pinctrl/ultrarisc,dp1000-pinctrl.h
> >  
> >  ULTRATRONIK BOARD SUPPORT
> > diff --git a/drivers/pinctrl/Kconfig b/drivers/pinctrl/Kconfig
> > index 03f2e3ee065f..76105be8b395 100644
> > --- a/drivers/pinctrl/Kconfig
> > +++ b/drivers/pinctrl/Kconfig
> > @@ -711,5 +711,6 @@ source "drivers/pinctrl/ti/Kconfig"
> >  source "drivers/pinctrl/uniphier/Kconfig"
> >  source "drivers/pinctrl/visconti/Kconfig"
> >  source "drivers/pinctrl/vt8500/Kconfig"
> > +source "drivers/pinctrl/ultrarisc/Kconfig"
> 
> u < v
> 
> Do not add to the end of files. You are messing how this file is sorted.
>

Thanks, will fix the ordering.

> >  
> >  endif
> > diff --git a/drivers/pinctrl/Makefile b/drivers/pinctrl/Makefile
> > index f7d5d5f76d0c..4df3e52518ea 100644
> > --- a/drivers/pinctrl/Makefile
> > +++ b/drivers/pinctrl/Makefile
> > @@ -98,3 +98,4 @@ obj-y				+= ti/
> >  obj-$(CONFIG_PINCTRL_UNIPHIER)	+= uniphier/
> >  obj-$(CONFIG_PINCTRL_VISCONTI)	+= visconti/
> >  obj-$(CONFIG_ARCH_VT8500)	+= vt8500/
> > +obj-$(CONFIG_ARCH_ULTRARISC)	+= ultrarisc/
> 
> Missing compile test. Don't use that style. See other decent SoC vendors
> how they solved that problem.
> 
> Also, do not add to the end of the files. Keep things sorted, more or less.
> 
>

Will fix the ordering and follow the recommended SoC build style in v2.
 
> > diff --git a/drivers/pinctrl/ultrarisc/Kconfig b/drivers/pinctrl/ultrarisc/Kconfig
> > new file mode 100644
> > index 000000000000..ba8747b90127
> > --- /dev/null
> > +++ b/drivers/pinctrl/ultrarisc/Kconfig
> > @@ -0,0 +1,23 @@
> > +# SPDX-License-Identifier: GPL-2.0-only
> > +
> > +config PINCTRL_ULTRARISC
> > +	tristate
> > +	depends on OF
> > +	select PINMUX
> > +	select GENERIC_PINCTRL_GROUPS
> > +	select GENERIC_PINCONF
> > +	select GENERIC_PINMUX_FUNCTIONS
> > +	select GPIOLIB
> > +	select IRQ_DOMAIN_HIERARCHY
> > +	select MFD_SYSCON
> > +
> 
> 
> Best regards,
> Krzysztof
> 

Best regards,
Jia Wang