[PATCH] iommu/riscv: prefer WSI on IGS=BOTH when wired IRQs are described

Andrew Jones andrew.jones at oss.qualcomm.com
Wed May 20 09:03:23 PDT 2026


On Wed, May 20, 2026 at 09:44:16PM +0800, fangyu.yu at linux.alibaba.com wrote:
...
> >(As a side note, is there a reason this is calling of_msi_configure() on 
> >a platform device when of_platform_device_create_pdata() will have done 
> >that already?)
> 
> Good catch, agreed.
>

This is here for a device creation order issue. We have similar patterns
elsewhere, e.g. drivers/irqchip/irq-riscv-rpmi-sysmsi.c:268. When the
device is created the MSI controller may not yet have been probed, so
msi_domain will be NULL. The of_msi_configure() here ensures it gets a
second chance. Anup says he has a device driver framework solution to
avoid this pattern that he intends to post soon. I'll clean this up
after that.

Thanks,
drew



More information about the linux-riscv mailing list