[PATCH v2 09/12] reset: starfive: Introduce assert_polarity

[Philipp Zabel]

On Di, 2026-05-12 at 01:35 -0700, Changhuang Liang wrote:
> The JHB100 SoC supports inverted operations for reset
> assertion/deassertion, introducing the an assert_polarity field to
> distinguish between different operation logics.
> 
> Signed-off-by: Changhuang Liang <changhuang.liang at starfivetech.com>
> ---
>  drivers/reset/starfive/reset-starfive-common.c | 18 +++++++++++++++---
>  drivers/reset/starfive/reset-starfive-common.h |  6 ++++++
>  2 files changed, 21 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/reset/starfive/reset-starfive-common.c b/drivers/reset/starfive/reset-starfive-common.c
> index 8ea142ecbd15..c7289c2b2a28 100644
> --- a/drivers/reset/starfive/reset-starfive-common.c
> +++ b/drivers/reset/starfive/reset-starfive-common.c
> @@ -68,7 +68,7 @@ static int starfive_reset_update(struct reset_controller_dev *rcdev,
>  	reg_status = data->status + offset * sizeof(u32);
>  	done = data->asserted ? data->asserted[offset] & mask : 0;
>  
> -	if (!assert)
> +	if (data->info && data->info->assert_polarity == assert)
>  		done ^= mask;
>  
>  	spin_lock_irqsave(&data->lock, flags);
> @@ -90,13 +90,25 @@ static int starfive_reset_update(struct reset_controller_dev *rcdev,
>  static int starfive_reset_assert(struct reset_controller_dev *rcdev,
>  				 unsigned long id)
>  {
> -	return starfive_reset_update(rcdev, id, true);

Please keep this.

> +	struct starfive_reset *data = starfive_reset_from(rcdev);
> +	bool assert = true;
> +
> +	if (data->info && data->info->assert_polarity)
> +		assert = false;

And move this into starfive_reset_update().

Consider renaming assert_polarity to active_low or similar, to align
nomenclature with other drivers.

> +
> +	return starfive_reset_update(rcdev, id, assert);
>  }
>  
>  static int starfive_reset_deassert(struct reset_controller_dev *rcdev,
>  				   unsigned long id)
>  {
> -	return starfive_reset_update(rcdev, id, false);
> +	struct starfive_reset *data = starfive_reset_from(rcdev);
> +	bool deassert = false;
> +
> +	if (data->info && data->info->assert_polarity)
> +		deassert = true;

Same as for starfive_reset_assert().

regards
Philipp