[PATCH v1 1/2] LRW UART: dt-bindings: Add binding for LRW UART

[Krzysztof Kozlowski]

On 13/05/2026 10:43, liu.qingtao2 at zte.com.cn wrote:
> Thanks for your kindly review. Sorry for the delay.
> 
>> On 13/02/2026 10:33, LiuQingtao wrote:
>>> From: Wenhong Liu <liu.wenhong35 at zte.com.cn>
>>>
>>> Add documentation for LRW UART devicetree bindings.
>>>
>>> Signed-off-by: Wenhong Liu <liu.wenhong35 at zte.com.cn>
>>> Signed-off-by: Qingtao Liu <liu.qingtao2 at zte.com.cn>
>>
>> Please use subject prefixes matching the subsystem. You can get them for
>> example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory
>> your patch is touching. For bindings, the preferred subjects are
>> explained here:
>> https://www.kernel.org/doc/html/latest/devicetree/bindings/submitting-patches.html#i-for-patch-submitters
>>
>>
>> A nit, subject: drop second/last, redundant "bindings". The
>> "dt-bindings" prefix is already stating that these are bindings.
>> See also:
>> https://elixir.bootlin.com/linux/v6.17-rc3/source/Documentation/devicetree/bindings/submitting-patches.rst#L18
> 
> Thanks for the notice. I will change the subject to "Add devicetree binding for ZTE LRX UART controller"
> in the v2 patch series.

NAK. Read the comment again. You improved nothing.

> 
> 
>>> ---
>>>  .../bindings/serial/lrw,lrw-uart.yaml         | 49 +++++++++++++++++++
>>>  .../devicetree/bindings/vendor-prefixes.yaml  |  2 +
>>>  MAINTAINERS                                   |  7 +++
>>>  3 files changed, 58 insertions(+)
>>>  create mode 100644 Documentation/devicetree/bindings/serial/lrw,lrw-uart.yaml
>>>
>>> diff --git a/Documentation/devicetree/bindings/serial/lrw,lrw-uart.yaml b/Documentation/devicetree/bindings/> serial/lrw,lrw-uart.yaml
>>> new file mode 100644
>>> index 000000000000..a2d41c278c4f
>>> --- /dev/null
>>> +++ b/Documentation/devicetree/bindings/serial/lrw,lrw-uart.yaml
>>> @@ -0,0 +1,49 @@
>>> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
>>> +
>>> +%YAML 1.2
>>> +---
>>> +$id: http://devicetree.org/schemas/serial/lrw-uart.yaml#
>>
>> Never tested, NAK. There are several other issues here, but I am not
>> going through rest of review if you did not bother to even build test
>> it. Please open any other recent binding and apply same style here
>> (filename, descriptions etc), so you won't be repeating SAME mistakes.
>>
>>
> 
> Sorry, i tested on an older version kernel.
> No errors or warnings ever showed up running the command
> "make dt_binding_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/serial/zte,lrx-uart.yaml".
> 

Don't work on older kernel. It's not an excuse.

Best regards,
Krzysztof