[PATCH v3 1/2] riscv: dts: spacemit: add fixed regulators for OrangePi R2S
Chukun Pan
amadeus at jmu.edu.cn
Tue May 12 23:00:30 PDT 2026
Hi,
> please check my comment below, I think this patch has similar issue
>
> https://lore.kernel.org/all/20260511065338-GKA3624147@kernel.org/
I don't think this is an issue. Otherwise, these commits need to be fixed:
https://github.com/torvalds/linux/commit/1df07a40453fd652132051419140950d47941fe9
https://github.com/torvalds/linux/commit/ae9d03f8aec76c1bff21083b67c211238d7c57b1
Let's confirm the current DT preferred:
- regulator-fixed
nodename: Preferred name is 'regulator-[0-9]v[0-9]'
gpio/gpios: Preferred 'gpios'
https://github.com/torvalds/linux/commit/12df2c182ccb850988d2680a422211a812fb5cb2
There is no specification or preference stating that regulators without
software or GPIO control should be removed.
This has been discussed many times, and people are used to describing DT
according to the schematic:
https://lore.kernel.org/all/44ba02e34d7bf6a6657894802a87b690@manjaro.org/
Therefore, if you consider these regulators unacceptable, we should remove
them from other dts in spacemit, or allow such changes.
Thanks,
Chukun
More information about the linux-riscv
mailing list