[PATCH] riscv: propagate insert_resource result from add_resource
Thorsten Blum
thorsten.blum at linux.dev
Tue May 12 05:46:28 PDT 2026
Currently, add_resource() returns 1 on success, even though its callers
only check for negative values. Instead, propagate the insert_resource()
result from add_resource() to align with standard kernel return-value
conventions (0 on success, negative errno on failure).
Signed-off-by: Thorsten Blum <thorsten.blum at linux.dev>
---
arch/riscv/kernel/setup.c | 8 +++-----
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/arch/riscv/kernel/setup.c b/arch/riscv/kernel/setup.c
index c89cc272440b..6e3d8acae71a 100644
--- a/arch/riscv/kernel/setup.c
+++ b/arch/riscv/kernel/setup.c
@@ -71,16 +71,14 @@ static struct resource *standard_resources;
static int __init add_resource(struct resource *parent,
struct resource *res)
{
- int ret = 0;
+ int ret;
ret = insert_resource(parent, res);
- if (ret < 0) {
+ if (ret < 0)
pr_err("Failed to add a %s resource at %llx\n",
res->name, (unsigned long long) res->start);
- return ret;
- }
- return 1;
+ return ret;
}
static int __init add_kernel_resources(void)
More information about the linux-riscv
mailing list