[RFC v1 0/4] generic pinmux dt_node_to_map implementation

Linus Walleij linusw at kernel.org
Mon May 11 13:23:16 PDT 2026


On Wed, May 6, 2026 at 11:58 AM Conor Dooley <conor at kernel.org> wrote:

> Whipped this up last week, at to a first glance it appears to work,
> although the spacemit platform I've used to implement this has very
> limited in-tree use of pinctrl so it is hard to be sure.

I like it, if it wasn't RFC I would merge it.

> What I don't love though is how similar the functions
> pinctrl_generic_pins_function_dt_node_to_map() and
> pinctrl_generic_pinmux_dt_node_to_map() are - essentially identical
> other than which function they in turn call.

Hm we can maybe think of something more descriptive
to the first one?

I think the new function is very much to the point. That's what
it does. pinctrl_generic_pins_function_dt_node_to_map() could
perhaps be names something that make it evident what is
special about it. Not that I have a good idea.

> Basically, I wanna know if you think that that is acceptable,

Looks Good To Me (TM) no-one else is helping out with pin
control core work so I'm happy for everything I get.

Yours,
Linus Walleij



More information about the linux-riscv mailing list