[PATCH v1 02/20] pinctrl: starfive: Add StarFive JHB100 sys0 controller driver

[Changhuang Liang]

Hi, Linus

Thanks for the review.

> Hi Changhuang,
> 
> thanks for your patch!
> 
> On Fri, Apr 24, 2026 at 1:13 PM Changhuang Liang
> <changhuang.liang at starfivetech.com> wrote:
> 
> > Add pinctrl driver for StarFive JHB100 SoC System-0(sys0) pinctrl
> > controller.
> >
> > Signed-off-by: Lianfeng Ouyang <lianfeng.ouyang at starfivetech.com>
> > Signed-off-by: Changhuang Liang <changhuang.liang at starfivetech.com>
> 
> (...)
> 
> > +config PINCTRL_STARFIVE_JHB100
> > +       bool
> > +       select GENERIC_PINCONF
> > +       select GENERIC_PINCTRL_GROUPS
> > +       select GENERIC_PINMUX_FUNCTIONS
> 
> Neat that you use the generic stuff!
> 
> > +#include <linux/pinctrl/consumer.h>
> 
> Do you really need the consumer header?

Here you need to reference these two functions:

pinctrl_gpio_request();
pinctrl_gpio_free();

Best Regards,
Changhuang