[PATCH v8 8/9] riscv: dts: spacemit: k1-bananapi-f3: add SD card support with UHS modes
Iker Pedrosa
ikerpedrosam at gmail.com
Mon May 11 01:01:58 PDT 2026
El sáb, 9 may 2026 a las 1:10, Yixun Lan (<dlan at kernel.org>) escribió:
>
>
> On 22:53 Fri 08 May , Yixun Lan wrote:
> > Hi Iker, Troy,
> >
> ..
> > I would object to add CONFIG_I2C_K1 as hard dependency, the reason is
> > that the spacemit sdhci driver (sdhci-of-k1.c) has no used i2c
> > api/function, it's just need I2C function via an indirect requirement,
> > which sdhci -> regulator(p1) -> i2c, besides, from the hardware design
> > perspective, it just happens that K1 use P1(via I2C) as PMIC, it's
> > totally possible(even in theory) to use other PMIC as power supply
> > control which may not be I2C interface (maybe use SPI, for example)
> >
> > If we want to solve this more gracefully, I'm in favor to add explict
> > option enabled in defconfig..
> >
> or I think it's better we do this way..
>
> +++ b/drivers/i2c/busses/Kconfig
> @@ -794,6 +794,7 @@ config I2C_K1
> tristate "SpacemiT K1 I2C adapter"
> depends on ARCH_SPACEMIT || COMPILE_TEST
> depends on OF
> + default ARCH_SPACEMIT
Thank you all for the feedback! I agree that enabling I2C_K1 by
default makes sense for the user experience.
To keep this patchset focused and avoid cross-subsystem complexity,
I'll send the I2C default configuration change as a separate patch to
the I2C maintainers after this series lands.
This way we can get the SD card support merged without delays while
still solving the dependency issue properly.
>
>
> --
> Yixun Lan (dlan)
More information about the linux-riscv
mailing list